-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symfony/service-contracts 3 #1436
Allow symfony/service-contracts 3 #1436
Conversation
How urgent is to release this now and why wasn't this issue spotted while working on #1434? |
Now i can't install orm pack in fresh symfony 6, i think it's criticall |
You don't need orm pack, require doctrine/doctrine-bundle and doctrine/orm explicitly. |
I meant that I cannot install the orm-pack because it requires a doctrine/doctrine-bundle, which cannot be installed just for the reason that is fixed in this pull request (it's possible only with downgrade symfony/service-contracts to 2.5) |
Could someone enlighten me why was this never an issue in our CI? https://github.com/doctrine/DoctrineBundle/runs/4365437825?check_suite_focus=true, concretely in "Install dependencies with Composer" step. This is what it installs:
This lead me to think there are no issues with compatibility. Only dependency it's still using symfony 5.x for is framework-bundle (because of psalm/psalm-plugin-symfony#227) and this one doesn't require service-contracts. I would like to improve our CI. |
Our CI does not try to install doctrine-bundle in an existing Symfony project by performing a partial update (as done by |
Because I solved a problem for 5.4 and not 6.0. Sorry, I did not investigate further. I probably should've. 😓 |
In PR #1434 was allowed deprecation-contracts 3 but now fresh symfony 6 installation need also service-contracts 3